[Cpan-forum-commit] rev 98 - in trunk: lib/CPAN templates

[svn at pti.co.il]

Author: gabor
Date: 2005-02-06 13:48:16 +0200 (Sun, 06 Feb 2005)
New Revision: 98

Modified:
   trunk/lib/CPAN/Forum.pm
   trunk/templates/about.tmpl
Log:
some cleanup, move the messages.log to the db directory

Modified: trunk/lib/CPAN/Forum.pm
===================================================================
--- trunk/lib/CPAN/Forum.pm	2005-02-06 11:26:56 UTC (rev 97)
+++ trunk/lib/CPAN/Forum.pm	2005-02-06 11:48:16 UTC (rev 98)
@@ -441,7 +441,7 @@
 This can be done by de-coupleing the name of the distribution from the posts table for all the distributions or we can add such an extra table for the additional distributions so there will be a leading distro of the thread.
 
 
-- Getting the listing of all ~7000 module names takes a long time.
+- Getting the listing of all ~8000 module names takes a long time.
 I should profile it.
 1) write a small script that will run the relevant code on the command line,
 2) time this
@@ -449,9 +449,6 @@
 on the web. Other solutions: 
 - type in the name
 - search for the name
-- currently we'll keep a separate file called db/modules.txt with a listing of all
-the distros. This make page generation in 1-2 sec instead of 7-8. Obviously
-there is a problem we'll have to fix.
 
 
 - Create a group for 
@@ -557,13 +554,15 @@
 sub cgiapp_init {
 	my $self = shift;
 	my $dbh = CPAN::Forum::DBI::db_Main();
+	
+	my $log = $self->param("ROOT") . "/db/messages.log";
 
 	$self->log_config(
 		LOG_DISPATCH_MODULES => [
 		{
 			module            => 'Log::Dispatch::File',
 			name              => 'messages',
-			filename          => '/tmp/messages.log',
+			filename          => $log,
 			min_level         => 'debug',
 			mode              => 'append',
 			close_after_write => 1,
@@ -1129,17 +1128,6 @@
 		}
 	}
 
-
-	my $cache = $self->param("ROOT") . "/db/modules.txt";
-	if (not @group_ids and open my $fh, $cache) {
-		foreach my $line (<$fh>) {
-			chomp $line;
-			my ($id, $name) = split /:/, $line, 2;
-			push @group_ids, $id;
-			$group_labels{$id} = $name;
-		}
-	}
-
 	if (not @group_ids) {
 		my @groups = CPAN::Forum::Groups->search(gtype => $CPAN::Forum::DBI::group_types{Distribution});
 		foreach my $g (@groups) {
@@ -1161,18 +1149,10 @@
 }
 
 
-
 sub new_post {
 	posts(@_);
 }
 
-
-=head2 response_form
-
-Probably obsolete.
-
-=cut
-
 sub response_form {
 	posts(@_);
 }

Modified: trunk/templates/about.tmpl
===================================================================
--- trunk/templates/about.tmpl	2005-02-06 11:26:56 UTC (rev 97)
+++ trunk/templates/about.tmpl	2005-02-06 11:48:16 UTC (rev 98)
@@ -80,7 +80,6 @@
 	<p class="about_title">TODO</p>
 	<ul>
 		<li> Improve the markup language</li>
-		<li> Paging through all the messages </li>
 		<li> Enable module authors to configure some aspects of the section of their own module</li>
 		<li> Posting a message under more than one distribution</li>
 		<li> Create larger discussion groups (e.g. Web development and All)</li>
@@ -88,7 +87,7 @@
 		<li> xml version of the search results</li>
 		<li> Admin: hide a comment, disable posting to a distibution, hide a distribution and all 
 			its postings</li>
-		<li> Admin: disable user, change e-mail address, change username ?</li>
+		<li> Admin: disable user, change username ?</li>
 		<li> Statistics on posts, views etc.</li>
 		<li> Other (human) languages (?)</li>
 		<li> Enable sending direct mail to a poster (?) (without disclosing e-mail address)</li>