[Cpan-forum-commit] rev 35 - in trunk: . lib/CPAN

[svn at pti.co.il]

Author: gabor
Date: 2005-01-25 21:51:39 +0200 (Tue, 25 Jan 2005)
New Revision: 35

Modified:
   trunk/Build.PL
   trunk/lib/CPAN/Forum.pm
Log:
suggestions from Shlomi, newer CGI::Application required

Modified: trunk/Build.PL
===================================================================
--- trunk/Build.PL	2005-01-25 18:54:19 UTC (rev 34)
+++ trunk/Build.PL	2005-01-25 19:51:39 UTC (rev 35)
@@ -15,7 +15,7 @@
 	requires            => {
 		'HTML::Template'                        => 2.6,
 		'CGI'                                   => 0,
-		'CGI::Application'                      => 3.22,
+		'CGI::Application'                      => 3.31,
 		'CGI::Application::Plugin::Session'     => 0,
 		'CGI::Application::Plugin::LogDispatch' => 0,
 		

Modified: trunk/lib/CPAN/Forum.pm
===================================================================
--- trunk/lib/CPAN/Forum.pm	2005-01-25 18:54:19 UTC (rev 34)
+++ trunk/lib/CPAN/Forum.pm	2005-01-25 19:51:39 UTC (rev 35)
@@ -449,6 +449,20 @@
 
 - favicon.ico and a banner image would be good
 
+
+Shlomi:
+The Forum uses cgiapp_prerun to set the mode according to the PATH_INFO instead of 
+using a mode_param code-reference. This causes a lot of warnings in the logs, 
+and doesn't really belong in cgiapp_prerun.
+
+It cannot be hosted on a URL except for its own virtual host, as it uses 
+absolute URLs. ("/login/", "/register/", etc.) A better idea would be to 
+track the path that the web-server gives (it's in one of the environment 
+variables) and then to construct a /cpan-forum/login/ /cpan-forum/register/ 
+etc. path. (or use relative URLs).
+
+
+
 =head1 METHODS
 
 =head2 cgiapp_init