[Cpan-forum-commit] rev 135 - trunk/lib/CPAN

[svn at pti.co.il]

Author: gabor
Date: 2005-03-22 22:52:59 +0200 (Tue, 22 Mar 2005)
New Revision: 135

Modified:
   trunk/lib/CPAN/Forum.pm
Log:
adding some log messages on the way to try to eliminate excessiove session creation

Modified: trunk/lib/CPAN/Forum.pm
===================================================================
--- trunk/lib/CPAN/Forum.pm	2005-03-22 15:44:49 UTC (rev 134)
+++ trunk/lib/CPAN/Forum.pm	2005-03-22 20:52:59 UTC (rev 135)
@@ -526,8 +526,8 @@
 	my $self = shift;
 	my $dbh = CPAN::Forum::DBI::db_Main();
 	
-	my $log = $self->param("ROOT") . "/db/messages.log";
-	$STATUS_FILE = $self->param("ROOT") . "/db/status";
+	my $log       = $self->param("ROOT") . "/db/messages.log";
+	$STATUS_FILE  = $self->param("ROOT") . "/db/status";
 	my $log_level = $self->_set_log_level();
 
 	$self->log_config(
@@ -547,8 +547,10 @@
 	$self->log->debug("--- START ---");
 	
 
+	$self->log->debug("Cookie received: "  . $self->query->cookie($cookiename) );
 	CGI::Session->name($cookiename);
 	$self->session_config(
+		#CGI_SESSION_OPTIONS => [ "driver:File", $self->query, {Directory => "/tmp"}],
 		CGI_SESSION_OPTIONS => [ "driver:SQLite", $self->query, {Handle => $dbh}],
 		COOKIE_PARAMS       => {
 				-expires => '+24h',
@@ -556,8 +558,9 @@
 		},
 		SEND_COOKIE         => 1,
 	);
+	$self->log->debug("sid:  " . ($self->session->id() || ""));
 	
-	$self->header_props( 
+	$self->header_props(
 		-expires => '-1d',  
 		# I think this this -expires causes some strange behaviour in IE 
 		# on the other hand it is needed in Opera to make sure it won't cache pages.
@@ -686,6 +689,7 @@
 
 	$self->log->debug("Current runmode:  $rm"); 
 	$self->log->debug("Current user:  " . ($self->session->param("username") || ""));
+	$self->log->debug("Current sid:  " . ($self->session->id() || ""));
 
 	return if grep {$rm eq $_} @free_modes;
 	#return if not grep {$rm eq $_} @restricted_modes;
@@ -907,6 +911,7 @@
 	}
 	$self->log->debug("Username: " . $user->username);
 
+	#$self->session_cookie();
 	my $session = $self->session;
 	$session->param(admin     => 0); # make sure it is clean
 
@@ -926,6 +931,7 @@
 	my $request = $session->param("request") || "";
 	$session->param("request" => "");
 	$session->flush();
+	$self->log->debug("Session flushed after login " . $session->param('loggedin'));
 	$self->header_type("redirect");
 	$request .= "/" if $request !~ m{/$};
 	$self->header_props(-url => "http://$ENV{HTTP_HOST}/$request");
@@ -1368,7 +1374,7 @@
 	push @errors, "invalid_subject" if $new_subject and $new_subject !~ m{^$SUBJECT$};
 	
 	push @errors, "no_text"    if not $new_text;
-	push @errors, "subject_too_long" if $new_subject and length($new_subject) > 50;
+	push @errors, "subject_too_long" if $new_subject and length($new_subject) > 80;
 
 	$self->log->debug("username: " . 
 				$self->session->param("username") . 
@@ -2272,6 +2278,16 @@
 	$_[0]->load_tmpl("site_is_closed.tmpl")->output;
 }
 
+sub teardown {
+	my ($self) = @_;
+	$self->log->debug("teardown called");
+	if (not  $self->session->param('loggedin') ) {
+		$self->log->debug("not logged in, but not deleting session");
+		#$self->session->delete();
+		#$self->session->flush();
+	}
+}
+
 1;
 
 =head1 ACKNOWLEDGEMENTS