[Cpan-forum-commit] rev 136 - trunk/lib/CPAN

[svn at pti.co.il]

Author: gabor
Date: 2005-03-22 23:25:13 +0200 (Tue, 22 Mar 2005)
New Revision: 136

Modified:
   trunk/lib/CPAN/Forum.pm
Log:
cleaning up the header and cookie issues stop setting cookies and creating sessions for everyone, do it only on the login page

Modified: trunk/lib/CPAN/Forum.pm
===================================================================
--- trunk/lib/CPAN/Forum.pm	2005-03-22 20:52:59 UTC (rev 135)
+++ trunk/lib/CPAN/Forum.pm	2005-03-22 21:25:13 UTC (rev 136)
@@ -556,7 +556,7 @@
 				-expires => '+24h',
 				-path    => '/',
 		},
-		SEND_COOKIE         => 1,
+		SEND_COOKIE         => 0,
 	);
 	$self->log->debug("sid:  " . ($self->session->id() || ""));
 	
@@ -566,7 +566,7 @@
 		# on the other hand it is needed in Opera to make sure it won't cache pages.
 		-charset => "utf-8",
 	);
-	$self->session_cookie();
+	#$self->session_cookie();
 }
 
 sub _set_log_level {
@@ -874,6 +874,7 @@
 	my ($self, $errs) = @_;
 	my $q = $self->query;
 
+	$self->session_cookie();
 	my $t = $self->load_tmpl(
 			"login.tmpl",
 			associate => $q,
@@ -911,7 +912,6 @@
 	}
 	$self->log->debug("Username: " . $user->username);
 
-	#$self->session_cookie();
 	my $session = $self->session;
 	$session->param(admin     => 0); # make sure it is clean
 
@@ -2281,9 +2281,10 @@
 sub teardown {
 	my ($self) = @_;
 	$self->log->debug("teardown called");
-	if (not  $self->session->param('loggedin') ) {
-		$self->log->debug("not logged in, but not deleting session");
-		#$self->session->delete();
+	my $rm = $self->get_current_runmode();
+	if (not  $self->session->param('loggedin')  and $rm ne "login") {
+		$self->log->debug("not logged in, deleting session");
+		$self->session->delete();
 		#$self->session->flush();
 	}
 }