[Cpan-forum-commit] rev 331 - in trunk: . lib/CPAN/Forum lib/CPAN/Forum/DB lib/CPAN/Forum/RM

svn at pti.co.il svn at pti.co.il
Mon Aug 13 22:16:05 EEST 2007


Author: gabor
Date: 2007-08-13 22:16:05 +0300 (Mon, 13 Aug 2007)
New Revision: 331

Modified:
   trunk/
   trunk/lib/CPAN/Forum/DB/Users.pm
   trunk/lib/CPAN/Forum/DBI.pm
   trunk/lib/CPAN/Forum/RM/Search.pm
Log:
add lists_users_like method to DB::Users



Property changes on: trunk
___________________________________________________________________
Name: svk:merge
   - 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4412
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752
   + 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4416
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752

Modified: trunk/lib/CPAN/Forum/DB/Users.pm
===================================================================
--- trunk/lib/CPAN/Forum/DB/Users.pm	2007-08-13 18:44:14 UTC (rev 330)
+++ trunk/lib/CPAN/Forum/DB/Users.pm	2007-08-13 19:16:05 UTC (rev 331)
@@ -83,5 +83,13 @@
     $dbh->do($sql, undef, @values, $id);
 }
 
+sub list_users_like {
+    my ($self, $username) = @_;
+    $username = "%" . $username . "%";
+    my $sql = "SELECT username FROM users WHERE username LIKE ? ORDER BY username";
+    
+    return $self->_fetch_arrayref_of_hashes($sql, $username);
+}
+
 1;
 

Modified: trunk/lib/CPAN/Forum/DBI.pm
===================================================================
--- trunk/lib/CPAN/Forum/DBI.pm	2007-08-13 18:44:14 UTC (rev 330)
+++ trunk/lib/CPAN/Forum/DBI.pm	2007-08-13 19:16:05 UTC (rev 331)
@@ -195,6 +195,8 @@
     return;
 }
 
+# _prep_where({ field => value, field2 => value2 });
+# return("field=? AND field2=?",    value, value2);
 sub _prep_where {
     my ($self, $args) = @_;
     #Carp::cluck (Data::Dumper->Dump([$args], ['args']));

Modified: trunk/lib/CPAN/Forum/RM/Search.pm
===================================================================
--- trunk/lib/CPAN/Forum/RM/Search.pm	2007-08-13 18:44:14 UTC (rev 330)
+++ trunk/lib/CPAN/Forum/RM/Search.pm	2007-08-13 19:16:05 UTC (rev 331)
@@ -137,13 +137,10 @@
     my ($self, $t, $name, $what) = @_;
 
     my @things;
-    my $it =  CPAN::Forum::DB::Users->search_like(username => '%' . lc($name) . '%');
-    while (my $user  = $it->next) {
-        push @things, {username => $user->username};
-    }
-    $t->param(users => \@things);
+    my $users =  CPAN::Forum::DB::Users->list_users_like(lc($name)); # SQL
+    $t->param(users => $users);
     $t->param($what => 1);
-    return @things ? 1 : 0;
+    return @$users ? 1 : 0;
 }
 
 sub _search_posts {



More information about the Cpan-forum-commit mailing list