[Cpan-forum-commit] rev 333 - in trunk: . lib/CPAN lib/CPAN/Forum/DB

[svn at pti.co.il]

Author: gabor
Date: 2007-08-14 11:32:08 +0300 (Tue, 14 Aug 2007)
New Revision: 333

Modified:
   trunk/
   trunk/lib/CPAN/Forum.pm
   trunk/lib/CPAN/Forum/DB/Posts.pm
Log:
include the username, fname, lname in the data fetched about the individual post
use this information to display the post




Property changes on: trunk
___________________________________________________________________
Name: svk:merge
   - 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4417
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752
   + 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4420
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752

Modified: trunk/lib/CPAN/Forum/DB/Posts.pm
===================================================================
--- trunk/lib/CPAN/Forum/DB/Posts.pm	2007-08-13 19:16:41 UTC (rev 332)
+++ trunk/lib/CPAN/Forum/DB/Posts.pm	2007-08-14 08:32:08 UTC (rev 333)
@@ -23,9 +23,9 @@
     #Carp::croak("No post_id given") if not $post_id;
 
     my $sql = "SELECT posts.id, gid, uid, parent, thread, hidden, subject, text, date,
-                groups.name group_name, groups.pauseid
-                FROM posts, groups
-                WHERE posts.id=? AND posts.gid=groups.id";
+                groups.name group_name, groups.pauseid, username, fname, lname
+                FROM posts, groups, users
+                WHERE posts.id=? AND posts.gid=groups.id AND users.id=posts.uid";
     return $self->_fetch_single_hashref($sql, $post_id);
 }
 sub _get_latest_pid_by_uid {
@@ -185,6 +185,17 @@
     return $self->_fetch_arrayref_of_hashes($sql, $value);
 };
 
+sub posts_in_thread {
+    my ($self, $thread) = @_;
+    my $sql = "SELECT id,  FROM posts WHERE thread=?";
+
+    my $sql = "SELECT posts.id, gid, uid, parent, thread, hidden, subject, text, date,
+                groups.name group_name, groups.pauseid
+                FROM posts, groups
+                WHERE posts.thread=? AND posts.gid=groups.id ";
+    $self->_fetch_arrayref_of_hashes($sql, $thread);
+}
+
 sub add_post {
     my ($self, $data, $parent_post, $parent) = @_;
     $self->add('posts', $data);

Modified: trunk/lib/CPAN/Forum.pm
===================================================================
--- trunk/lib/CPAN/Forum.pm	2007-08-13 19:16:41 UTC (rev 332)
+++ trunk/lib/CPAN/Forum.pm	2007-08-14 08:32:08 UTC (rev 333)
@@ -1273,9 +1273,9 @@
     my ($self, $post) = @_;
     my $responses = CPAN::Forum::DB::Posts->list_posts_by(parent => $post->{id}); # SQL
 
-    my $user = CPAN::Forum::DB::Users->info_by(id => $post->{uid}); # SQL
+    #my $user = CPAN::Forum::DB::Users->info_by(id => $post->{uid}); # SQL
     my %post = (
-        postername  => $user->{username},
+        postername  => $post->{username},
         date        => _post_date($post->{date}),
         parentid    => $post->{parent},
         responses   => $responses,
@@ -1315,8 +1315,10 @@
 
 =head2 threads
 
-Show all the posts of a thread.
+Show all the posts of a single thread.
 
+/threads/NNN
+
 =cut
 
 sub threads {
@@ -1331,6 +1333,7 @@
     my $id = $q->param("id");
     $id = ${$self->param("path_parameters")}[0] if ${$self->param("path_parameters")}[0];
 
+    #my @posts = CPAN::Forum::DB::Posts->posts_in_thread($id);
     my @posts = CPAN::Forum::DB::Posts->search(thread => $id);
     if (not @posts) {
         return $self->internal_error(