[Cpan-forum-commit] rev 239 - in trunk: . lib/CPAN lib/CPAN/Forum/RM templates

[svn at pti.co.il]

Author: gabor
Date: 2007-07-04 00:02:47 +0300 (Wed, 04 Jul 2007)
New Revision: 239

Modified:
   trunk/
   trunk/lib/CPAN/Forum.pm
   trunk/lib/CPAN/Forum/RM/Update.pm
   trunk/templates/groups.tmpl
Log:
remove the RM_MAP table as it was not used an every module should be in
memory anyway under mod_perl
ad link to tags




Property changes on: trunk
___________________________________________________________________
Name: svk:merge
   - 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4098
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752
   + 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4099
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752

Modified: trunk/lib/CPAN/Forum/RM/Update.pm
===================================================================
--- trunk/lib/CPAN/Forum/RM/Update.pm	2007-07-03 21:02:20 UTC (rev 238)
+++ trunk/lib/CPAN/Forum/RM/Update.pm	2007-07-03 21:02:47 UTC (rev 239)
@@ -24,6 +24,7 @@
     $self->log->debug("_update_tags in group '$group_id' tags='$new_tags'");
     $new_tags =~ s/^\s+//;
     $new_tags =~ s/\s+$//;
+    $new_tags =~ s{<>/}{};
     my @tags = split /,/, lc $new_tags;
 
     my $uid = $self->session->param('uid');

Modified: trunk/lib/CPAN/Forum.pm
===================================================================
--- trunk/lib/CPAN/Forum.pm	2007-07-03 21:02:20 UTC (rev 238)
+++ trunk/lib/CPAN/Forum.pm	2007-07-03 21:02:47 UTC (rev 239)
@@ -510,7 +510,7 @@
     help
     rss
     atom
-    update
+    tags
 ); 
 my @restricted_modes = qw(
     new_post process_post
@@ -522,7 +522,9 @@
     add_new_group
     response_form 
     module_search
-    selfconfig change_password change_info update_subscription); 
+    selfconfig change_password change_info update_subscription
+    update
+); 
             
 my @urls = qw(
     logout 
@@ -540,6 +542,7 @@
     rss
     atom
     update
+    tags
 ); 
 
 use base 'CPAN::Forum::RM::Author';
@@ -553,46 +556,7 @@
 use base 'CPAN::Forum::RM::Subscriptions';
 use base 'CPAN::Forum::RM::UserAccounts';
 use base 'CPAN::Forum::RM::Update';
-my %RM_MAP = (
-    author                  => 'CPAN::Forum::RM::Author',
 
-    dist                    => 'CPAN::Forum::RM::Dist',
-
-    login                   => 'CPAN::Forum::RM::Login',
-    login_process           => 'CPAN::Forum::RM::Login',
-    logout                  => 'CPAN::Forum::RM::Login',
-    pwreminder              => 'CPAN::Forum::RM::Login',
-    pwreminder_process      => 'CPAN::Forum::RM::Login',
-
-    users                   => 'CPAN::Forum::RM::Users',
-
-    admin                   => 'CPAN::Forum::RM::Admin',
-    admin_process           => 'CPAN::Forum::RM::Admin',
-    admin_edit_user         => 'CPAN::Forum::RM::Admin',
-    admin_edit_user_process => 'CPAN::Forum::RM::Admin',
-
-    faq                     => 'CPAN::Forum::RM::Other',
-    about                   => 'CPAN::Forum::RM::Other',
-    stats                   => 'CPAN::Forum::RM::Other',
-
-    mypan                   => 'CPAN::Forum::RM::Subscriptions',
-    update_subscription     => 'CPAN::Forum::RM::Subscriptions',
-
-    notify                  => 'CPAN::Forum::RM::Notify',
-    notify_admin            => 'CPAN::Forum::RM::Notify',
-    rss                     => 'CPAN::Forum::RM::Notify',
-
-    module_search_form      => 'CPAN::Forum::RM::Search',
-    module_search           => 'CPAN::Forum::RM::Search',
-    search                  => 'CPAN::Forum::RM::Search',
-
-    selfconfig              => 'CPAN::Forum::RM::UserAccounts',
-    change_info             => 'CPAN::Forum::RM::UserAccounts',
-    change_password         => 'CPAN::Forum::RM::UserAccounts',
-
-    tags                    => 'CPAN::Forum::RM::Tags',
-);
-
 =head2 setup
 
 Standard CGI::Application method
@@ -627,14 +591,6 @@
     }
 
     my $rm = $self->_set_run_mode();
-    if ($RM_MAP{$rm}) {
-        ## no critic (ProhibitStringyEval)
-        $self->log->debug("Loading $RM_MAP{$rm}");
-        #eval "use base $RM_MAP{$rm}";
-        #if ($@) {
-        #    $self->log->critical("Could not load $RM_MAP{$rm}: $@");
-        #}
-    }
 
     $self->log->debug("Current runmode:  $rm");
     $self->log->debug("Current user:  " . ($self->session->param("username") || ""));

Modified: trunk/templates/groups.tmpl
===================================================================
--- trunk/templates/groups.tmpl	2007-07-03 21:02:20 UTC (rev 238)
+++ trunk/templates/groups.tmpl	2007-07-03 21:02:47 UTC (rev 239)
@@ -14,7 +14,7 @@
 <TMPL_IF show_tags>
 <p>
 <TMPL_IF tags>
-My Tags: <TMPL_LOOP tags><TMPL_VAR name>, </TMPL_LOOP>
+My Tags: <TMPL_LOOP tags><a href="/tags/name/<TMPL_VAR name>"><TMPL_VAR name></a>, </TMPL_LOOP>
 </TMPL_IF><br />
 <form method="post" action="/update/">
 <input type="hidden" name="what" value="tags" />