[Cpan-forum-commit] rev 250 - in trunk: . lib/CPAN/Forum/DB lib/CPAN/Forum/RM

[svn at pti.co.il]

Author: gabor
Date: 2007-07-19 08:49:45 +0300 (Thu, 19 Jul 2007)
New Revision: 250

Modified:
   trunk/
   trunk/lib/CPAN/Forum/DB/Configure.pm
   trunk/lib/CPAN/Forum/RM/Notify.pm
Log:
clean comments in DB::Configure
check if variable exists before dereferncing



Property changes on: trunk
___________________________________________________________________
Name: svk:merge
   - 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4136
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752
   + 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4137
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752

Modified: trunk/lib/CPAN/Forum/DB/Configure.pm
===================================================================
--- trunk/lib/CPAN/Forum/DB/Configure.pm	2007-07-19 05:49:31 UTC (rev 249)
+++ trunk/lib/CPAN/Forum/DB/Configure.pm	2007-07-19 05:49:45 UTC (rev 250)
@@ -3,8 +3,6 @@
 use warnings;
 use Carp;
 use base 'CPAN::Forum::DBI';
-#__PACKAGE__->table('configure');
-#__PACKAGE__->columns(All => qw/field value/);
 
 my %default = (
     flood_control_time_limit => 10,

Modified: trunk/lib/CPAN/Forum/RM/Notify.pm
===================================================================
--- trunk/lib/CPAN/Forum/RM/Notify.pm	2007-07-19 05:49:31 UTC (rev 249)
+++ trunk/lib/CPAN/Forum/RM/Notify.pm	2007-07-19 05:49:45 UTC (rev 250)
@@ -123,7 +123,7 @@
         id       => "$url/",
     );
  
-    if (@$it) {
+    if ($it and @$it) {
         foreach my $post (@$it) {
             my $title = sprintf "[%s] %s", $post->{group_name}, $post->{subject};
             my $author = {
@@ -167,7 +167,7 @@
     # TODO: replace this e-mail address with a configurable value
     $rss->webmaster('admin at cpanforum.com');
 
-    if (@$it) {
+    if ($it and @$it) {
         #while (my $post = $it->next() and $limit--) {
         #    my $title = sprintf "[%s] %s", $post->gid->name, $post->subject;
         #    $rss->item("$url/posts/" . $post->id(), $title); # TODO _subject_escape ?