[Cpan-forum-commit] rev 305 - in trunk: . lib/CPAN/Forum/RM

[svn at pti.co.il]

Author: gabor
Date: 2007-07-25 17:46:49 +0300 (Wed, 25 Jul 2007)
New Revision: 305

Modified:
   trunk/
   trunk/lib/CPAN/Forum/RM/Subscriptions.pm
Log:
shorten the mypan method,  refactoring if-else to ?:



Property changes on: trunk
___________________________________________________________________
Name: svk:merge
   - 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4325
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752
   + 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4326
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752

Modified: trunk/lib/CPAN/Forum/RM/Subscriptions.pm
===================================================================
--- trunk/lib/CPAN/Forum/RM/Subscriptions.pm	2007-07-25 14:46:23 UTC (rev 304)
+++ trunk/lib/CPAN/Forum/RM/Subscriptions.pm	2007-07-25 14:46:49 UTC (rev 305)
@@ -47,16 +47,11 @@
     $t->param(title    => "Information about $username");
 
     my @params = @{$self->param("path_parameters")};
-    my @subscriptions;
-    my $gids;
+    my ($gids, @subscriptions) = 
+            (@params == 2 and $params[0] eq "dist")
+            ?           $self->_get_module_subscription($user, $params[1])
+            :           $self->_get_all_subscriptions($user);
 
-
-    if (@params == 2 and $params[0] eq "dist") {
-        ($gids, @subscriptions) = $self->_get_module_subscription($user, $params[1]);
-    } else {
-        ($gids, @subscriptions) = $self->_get_all_subscriptions($user);
-    }
-
     $t->param(subscriptions => \@subscriptions);
     $t->param(gids => $gids);