[Cpan-forum-commit] rev 357 - in trunk: . bin lib/CPAN/Forum lib/CPAN/Forum/RM templates www

[svn at pti.co.il]

Author: gabor
Date: 2008-04-06 22:42:04 +0300 (Sun, 06 Apr 2008)
New Revision: 357

Modified:
   trunk/
   trunk/bin/setup.pl
   trunk/lib/CPAN/Forum/Build.pm
   trunk/lib/CPAN/Forum/DBI.pm
   trunk/lib/CPAN/Forum/RM/Subscriptions.pm
   trunk/lib/CPAN/Forum/RM/Update.pm
   trunk/templates/navigation.tmpl
   trunk/www/display_tags.js
   trunk/www/style.css
Log:
some cleanup



Property changes on: trunk
___________________________________________________________________
Name: svk:merge
   - 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:4589
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752
   + 7bc34947-122d-0410-bc5a-f898d2bb5f81:/local/cpan-forum:5315
8c4c90e1-83eb-0310-96eb-e7cb62807872:/local/cpan-forum:12752

Modified: trunk/bin/setup.pl
===================================================================
--- trunk/bin/setup.pl	2007-10-26 10:46:24 UTC (rev 356)
+++ trunk/bin/setup.pl	2008-04-06 19:42:04 UTC (rev 357)
@@ -45,7 +45,7 @@
 
 
 my $from = delete $opt{from};
-CPAN::Forum::DB::Configure->create({field => 'from', value => $from});
+CPAN::Forum::DB::Configure->set_field_value('from', $from);
 
 my $user = CPAN::Forum::DB::Users->create({id => 1, update_on_new_user => 1, %opt});
 $user->password($opt{password});

Modified: trunk/lib/CPAN/Forum/Build.pm
===================================================================
--- trunk/lib/CPAN/Forum/Build.pm	2007-10-26 10:46:24 UTC (rev 356)
+++ trunk/lib/CPAN/Forum/Build.pm	2008-04-06 19:42:04 UTC (rev 357)
@@ -22,7 +22,7 @@
     
     system "rm -rf blib";
     copy_tree(from => ".", dir => "blib");
-    replace_sh_bang("$Bin/blib", <blib/bin/* blib/www/cgi/*>);
+    replace_sh_bang("$Bin/blib", glob "blib/bin/* blib/www/cgi/*";
 }
 
 sub ACTION_install {
@@ -34,7 +34,7 @@
     }
 
     copy_tree(from => "blib", dir => $dir);
-    replace_sh_bang("$dir", <$dir/bin/* $dir/www/cgi/*>);
+    replace_sh_bang("$dir", glob "$dir/bin/* $dir/www/cgi/*");
 }
 
 # Replace the sh_bang line on each one of the scripts in the build directory

Modified: trunk/lib/CPAN/Forum/DBI.pm
===================================================================
--- trunk/lib/CPAN/Forum/DBI.pm	2007-10-26 10:46:24 UTC (rev 356)
+++ trunk/lib/CPAN/Forum/DBI.pm	2008-04-06 19:42:04 UTC (rev 357)
@@ -2,6 +2,7 @@
 use strict;
 use warnings;
 use Carp qw();
+use Data::Dumper ();
 
 use DBI;
 my $dbh;

Modified: trunk/lib/CPAN/Forum/RM/Subscriptions.pm
===================================================================
--- trunk/lib/CPAN/Forum/RM/Subscriptions.pm	2007-10-26 10:46:24 UTC (rev 356)
+++ trunk/lib/CPAN/Forum/RM/Subscriptions.pm	2008-04-06 19:42:04 UTC (rev 357)
@@ -208,6 +208,7 @@
     return $self->notes("mypanok");
 
 =pod
+
     # I think we don't need to provide this
     # A user either comes from the page of a Module ( /dist/Module-Name) 
     # and then we already have the value.
@@ -261,6 +262,7 @@
     }
 
     return $self->notes("mypanok");
+
 =cut
 
 }

Modified: trunk/lib/CPAN/Forum/RM/Update.pm
===================================================================
--- trunk/lib/CPAN/Forum/RM/Update.pm	2007-10-26 10:46:24 UTC (rev 356)
+++ trunk/lib/CPAN/Forum/RM/Update.pm	2008-04-06 19:42:04 UTC (rev 357)
@@ -26,7 +26,7 @@
     $new_tags =~ s/^\s+//;
     $new_tags =~ s/\s+$//;
     $new_tags =~ s{<>/}{};
-    my @tags = map {s/^\s+|\s+$//g; $_}  split /,/, lc $new_tags;
+    my @tags = map {s/^\s+|\s+$//g; $_}  split /,/, lc $new_tags; ## no critic
 
     my $uid = $self->session->param('uid');
 

Modified: trunk/templates/navigation.tmpl
===================================================================
--- trunk/templates/navigation.tmpl	2007-10-26 10:46:24 UTC (rev 356)
+++ trunk/templates/navigation.tmpl	2008-04-06 19:42:04 UTC (rev 357)
@@ -20,7 +20,7 @@
     </TMPL_IF>
     | <a href="/tags/">tags</a>
 ]
+<div class="perlads">
+<script type="text/javascript"  src="http://adserver.szabgab.com/ads/direct_link_selflink.js"></script>
 </div>
-<div class="navigation">
-<a href="http://perlsurvey.org/">Take the Perl Survey Now!</a>
 </div>

Modified: trunk/www/display_tags.js
===================================================================
--- trunk/www/display_tags.js	2007-10-26 10:46:24 UTC (rev 356)
+++ trunk/www/display_tags.js	2008-04-06 19:42:04 UTC (rev 357)
@@ -19,7 +19,6 @@
     var tags = cpan_forum_list_tags()
     var t =  document.getElementById('cpanforum_tags');
     for(var i=0; i<tags.length; i++) {
-        //alert(tags[i]);
         li = document.createElement('li');
         a  = document.createElement('a');
         a.setAttribute('href', 'javascript:cpan_forum_popup_tag("' + tags[i] + '")');
@@ -28,9 +27,20 @@
         li.appendChild(a);
         t.appendChild(li);
     }
-//    alert(tags.length);
+    
+    //text should be either add tags or update tags
+    
+    var link_text = (tags.length > 0 ? "update" : "add") + " tags";
+    li = document.createElement('li');
+    a  = document.createElement('a');
+    a.setAttribute('href', 'javascript:cpan_forum_popup("' + "qq" + '")');
+    var text = document.createTextNode(tags.length);
+    a.appendChild(text);
+    li.appendChild(a);
+    t.appendChild(li);
 }
 
+
 function cpan_forum_popup_tag(tag) {
     var w = window.open(cpan_forum_url + '/tags/name_popup/' + tag, 'cpan_forum_list_distros', "width=600,height=300,resizable=1");
     w.focus(1);

Modified: trunk/www/style.css
===================================================================
--- trunk/www/style.css	2007-10-26 10:46:24 UTC (rev 356)
+++ trunk/www/style.css	2008-04-06 19:42:04 UTC (rev 357)
@@ -42,6 +42,10 @@
 	padding-bottom:1px;
 /*	width: 780px;*/
 }
+.perlads li {
+    display: inline;
+    padding: 4px;
+}
 
 .message {
 	color: #000000;